refactor(platform): derive the checker version from the workflow pin - #29
Merged
Conversation
The wrapper hardcoded deploy-check 0.15.0, which is the same mistake the 400-line copy made with its schema version and context digest -- and 0.15.0 turned out to carry a context-resolution bug fixed in 0.15.1. deploy-check is released from the same repository as the reusable workflows, so the version comment on the deploy-validate (or deploy-artifact) pin is the version to run. The wrapper reads it from there, leaving nothing about the checker restated in this repository. The github-workflows pins move to v0.15.1 accordingly. Both reusable workflow interfaces are unchanged across the versions involved -- same inputs, same required flags -- so no caller change is needed.
ExtraToast
added
the
type: refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrapper landed with
deploy-checkpinned to0.15.0in the script itself — the same mistake the 400-line copy made with its schema version and context digest. And 0.15.0 turned out to carry a context-resolution bug, fixed in 0.15.1 (JorisJonkers-dev/github-workflows#95).deploy-checkis released from the same repository as the reusable workflows, so the version comment on thedeploy-validate(ordeploy-artifact) pin is the version to run. The wrapper reads it from there. Nothing about the checker is restated in this repository any more: the schema version, the context ref, and now the checker version all come from the workflow pins.The
github-workflowspins move to v0.15.1. Both reusable workflow interfaces are unchanged across every version involved — same inputs, samerequiredflags — so no caller change is needed.Verification
Run in all seven service repos against a deliberately nested context package, matching the layout
oras pullproduces in CI: each derives0.15.1from its own pins, renders five fragments, and scores. Six pass;knowledgeexits 1 on its knownhealth_declaredgap.